Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Implement a search + individual pages for the icons #14984

Closed
ousmaneMetso opened this issue Mar 21, 2019 · 8 comments · Fixed by #16956
Closed

[docs] Implement a search + individual pages for the icons #14984

ousmaneMetso opened this issue Mar 21, 2019 · 8 comments · Fixed by #16956
Labels
docs Improvements or additions to the documentation priority: important This change can make a difference

Comments

@ousmaneMetso
Copy link

Tried importing this from material-ui and its not working.
It says: Module not found: Can't resolve '@material-ui/icons/Delete'

@ffjanhoeck
Copy link
Contributor

Please check that you node_modules folder includes @material/icons, because it works pretty fine.
https://codesandbox.io/s/0oqo41426n

@joshwooding joshwooding added the status: waiting for author Issue with insufficient information label Mar 21, 2019
@joshwooding
Copy link
Member

We would need a reproduction, as demonstrated above it works on codesandbox.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 21, 2019

I was looking into the potential for improving the icons documentation page. We have two important leverages that we should use 🔥:

  • Implement a search. We have 1k icons, with 5 variants each. It's not always simple to use material.io to navigate them.
  • Leverage SEO for the 1k icons. We can make them easier to discover and generate more traffic.

@oliviertassinari oliviertassinari changed the title import DeleteIcon from '@material-ui/icons/Delete' not working [docs] Implement a search + individual pages for the icons Mar 21, 2019
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation priority: important This change can make a difference and removed status: waiting for author Issue with insufficient information labels Mar 21, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 21, 2019

Implement a search. We have 1k icons, with 5 variants each. It's not always simple to use material.io to navigate them.

I rather enjoyed https://material.io/tools/icons/ to be honest. What features do you think are lacking currently?

Leverage SEO for the 1k icons. We can make them easier to discover and generate more traffic.

I don't think that generates useful traffic. Somebody searching for an icon doesn't need a React component library for that.

@oliviertassinari oliviertassinari removed the priority: important This change can make a difference label Mar 21, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 21, 2019

I rather enjoyed https://material.io/tools/icons/ to be honest. What features do you think are lacking currently?

@eps1lon This way, we can provide the correct import code. We have started in this direction with #12720. I have the following user experience in mind https://fontawesome.com/icons/helicopter?style=solid. We can contextualize the icon in different contexts, we can provide the raw source, the import path, the different variants.

=> 60 views a day. That's one of the top StackOverflow problem encountered by our users.

I don't think that generates useful traffic. Somebody searching for an icon doesn't need a React component library for that.

The goal is to save people time. We can look at the search volume on Google. It's still early enough so we can correctly position ourselves:

  • "icons" Volume: 246 000/mo | CPC: $2.13
  • "material icons" Volume: 165 000/mo | CPC: $0.39
  • "react icons" Volume: 8 100/mo | CPC: $0.00
  • "material icons react"Volume: 0/mo | CPC: $0.00

I have removed the important flag as you are raising some concern about the value it can bring.

@ousmaneMetso
Copy link
Author

update: it works i had material-ui in my modules, but i still needed to do: npm install material-ui/icons.
I wonder why it comes as a separate package from material-ui

@oliviertassinari
Copy link
Member

I wonder why it comes as a separate package from material-ui

@ousmaneMetso Bundle size: https://bundlephobia.com/result?p=@material-ui/icons@3.0.2.

@mbrookes
Copy link
Member

What features do you think are lacking currently?

Aliases. It's hard to find certain icons without knowing their exact name. But it would be a huge job to improve that, and well outside the remit of Material-UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation priority: important This change can make a difference
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants