Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconMenu menuItems prop , does it exist? #1615

Closed
raptoria opened this issue Sep 9, 2015 · 3 comments
Closed

IconMenu menuItems prop , does it exist? #1615

raptoria opened this issue Sep 9, 2015 · 3 comments
Labels
component: icon button This is the name of the generic UI component, not the React module! component: Icon The React component. component: menu This is the name of the generic UI component, not the React module!

Comments

@raptoria
Copy link

raptoria commented Sep 9, 2015

I would like to be able to do this:

      <IconMenu iconButtonElement={ContentAdd} menuItems={menuItems} />

just like

      <DropDownMenu menuItems={menuItems} />
@raptoria raptoria changed the title IconMenu iconButtonElement prop not working IconMenu menuItems prop , doesn't exist? Sep 9, 2015
@raptoria raptoria changed the title IconMenu menuItems prop , doesn't exist? IconMenu menuItems prop , does it exist? Sep 9, 2015
@shaurya947
Copy link
Contributor

@raptoria not as of today it seems. You have to define children of type MenuItem inside your IconMenu element. See source code of documentation page for an example.

@shaurya947
Copy link
Contributor

@raptoria we're moving towards composable components, so providing a menuItems prop for IconMenu would not align with that. Therefore, we're probably not going to do that.

Check this issue: #27 for more info.

@raptoria
Copy link
Author

makes sense..I just learned about React Composable Components today 👍

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: Icon The React component. component: icon button This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: icon button This is the name of the generic UI component, not the React module! component: Icon The React component. component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oliviertassinari @shaurya947 @raptoria @zannager