Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark mode brighening based on elevation #18309

Closed
1 task done
cmeeren opened this issue Nov 10, 2019 · 4 comments · Fixed by #25522
Closed
1 task done

Support dark mode brighening based on elevation #18309

cmeeren opened this issue Nov 10, 2019 · 4 comments · Fixed by #25522
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Milestone
v5-beta

Comments

@cmeeren
Copy link
Contributor

cmeeren commented Nov 10, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

According to the MD spec, for dark mode, surfaces with higher elevation should use lighter grays.

Examples 🌈

MD spec

Relevant screenshot of spec:

image
@oliviertassinari oliviertassinari added this to the v5 milestone Nov 10, 2019
@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Nov 10, 2019
@oliviertassinari
Copy link
Member

@cmeeren Thank you for opening an issue. Yes, we will have to rework this point for v5 :)

@oliviertassinari oliviertassinari mentioned this issue Nov 15, 2019
Closed
1 task
@oliviertassinari oliviertassinari mentioned this issue Mar 6, 2020
Closed
@oliviertassinari oliviertassinari mentioned this issue May 20, 2020
Closed
@oliviertassinari oliviertassinari mentioned this issue Jun 23, 2020
Closed
@joshwooding joshwooding mentioned this issue Jul 11, 2020
Closed
1 task
@oliviertassinari oliviertassinari mentioned this issue Nov 14, 2020
Open
1 task
@miquelvir
Copy link

Any update? Is there any known workaround for now?

@oliviertassinari
Copy link
Member

@miquelvir Do you want to resume the effort of #21748?

@miquelvir
Copy link

I would love to, but i am not qualified to... I am learning js and React right now so I am a beginner here (I have more xp in Java and Python)

@m4theushw m4theushw mentioned this issue Mar 27, 2021
Merged
1 task
@ti1024 ti1024 mentioned this issue May 6, 2021
Closed
2 tasks
@dantman dantman mentioned this issue Aug 26, 2021
Open
1 task
@MrEbbinghaus MrEbbinghaus mentioned this issue Sep 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
v5-beta
3 participants
@oliviertassinari @cmeeren @miquelvir