We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Chip variant default value default does not follow the general api of standard.
default
standard
Many components use the variant value standard as default value (e.g. TextField, Tabs, Badge).
variant
For some reason, the Chip component uses the value default instead (types, PropTypes).
I think this should be changed from default to standard or filled.
filled
Fixing this would be a breaking change without much gain.
Is it worth the trouble? Should this be normalized somewhere, so it's less likely to happen again?
The PR, that introduced the variant prop: #12680
The text was updated successfully, but these errors were encountered:
@mbrookes A v5 breaking change?
Sorry, something went wrong.
This is loosely related to #13028
I really like standard as opposed to the current tautology of 'default' being the default value.
'default'
Successfully merging a pull request may close this issue.
The Chip variant default value
default
does not follow the general api ofstandard
.Summary 💡
Many components use the
variant
valuestandard
as default value (e.g. TextField, Tabs, Badge).For some reason, the Chip component uses the value
default
instead (types, PropTypes).I think this should be changed from
default
tostandard
orfilled
.Fixing this would be a breaking change without much gain.
Is it worth the trouble?
Should this be normalized somewhere, so it's less likely to happen again?
Additional context
The PR, that introduced the
variant
prop: #12680The text was updated successfully, but these errors were encountered: