Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab] Default fontSize being overwritten by media query #19265

Closed
elmeerr opened this issue Jan 16, 2020 · 4 comments · Fixed by #19342
Closed

[Tab] Default fontSize being overwritten by media query #19265

elmeerr opened this issue Jan 16, 2020 · 4 comments · Fixed by #19342
Labels
component: tabs This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@elmeerr
Copy link
Contributor

elmeerr commented Jan 16, 2020

Hi guys,

The tab uses styles from typography.button, which means that the default font-size is 14px (or 0.875rem) which is also of course material specs

This can be seen here

but here you can see that the default font-size is being set to 13px when the screen is bigger than 600px. Is that a desired behavior?

I would imagine that instead of breakpoints.up it should breakpoints.down...could you guys let me know?

Thanks in advance
@elmeerr elmeerr changed the title [Tabs]: default fontSize being overwritten by media query [Tab]: default fontSize being overwritten by media query Jan 16, 2020
@oliviertassinari
Copy link
Member

Duplicate of #15324?

@elmeerr
Copy link
Contributor Author

elmeerr commented Jan 16, 2020 •
edited
Loading

@oliviertassinari yeah I've seen this but as it was not really related to the fontSize itself, I decide to keep it appart. I don't see a reason for changing the default fontSize in this case so I would consider an issue (not strictly related to issue #15324 but it can be solved together).

@oliviertassinari oliviertassinari added component: tabs This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Jan 16, 2020
@oliviertassinari oliviertassinari added this to the v5 milestone Jan 16, 2020
@oliviertassinari oliviertassinari changed the title [Tab]: default fontSize being overwritten by media query [Tab] Default fontSize being overwritten by media query Jan 17, 2020
@oliviertassinari
Copy link
Member

@elmeerr What about we remove the font-size media query in the next minor (v4.9.0)? Do you want to work on it? :)

@oliviertassinari oliviertassinari removed this from the v5 milestone Jan 17, 2020
@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Jan 17, 2020
@elmeerr
Copy link
Contributor Author

elmeerr commented Jan 17, 2020

@oliviertassinari Sounds great! I'll work on that!

@oliviertassinari oliviertassinari added good first issue Great for first contributions. Enable to learn the contribution process. and removed ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Jan 19, 2020
@elmeerr elmeerr mentioned this issue Jan 22, 2020
Merged
@hzhz hzhz mentioned this issue Jul 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tab] Remove font-size media-query elmeerr/material-ui
2 participants
@oliviertassinari @elmeerr