Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Start after specific number of letters #19591

Closed
1 task done
minaairsupport opened this issue Feb 6, 2020 · 10 comments · Fixed by #20305
Closed
1 task done

[Autocomplete] Start after specific number of letters #19591

minaairsupport opened this issue Feb 6, 2020 · 10 comments · Fixed by #20305
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request waiting for 👍 Waiting for upvotes

Comments

@minaairsupport
Copy link

I suggest adding more option in filter options, one of them start filter after a specific number of letters

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

add startAfter to filterOptions that accept int

Examples 🌈

const filterOptions = createFilterOptions({
matchFrom: 'start',
stringify: option => option.title,
startAfter: 2
});

Motivation 🔦

it will give us more control and I am thinking its not just me requesting this one

@oliviertassinari
Copy link
Member

What's the use case?

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Feb 6, 2020
@elilondon
Copy link

We need to open the AutoComplete menu/list of options after two key strokes and thought it made sense to come from filter. @oliviertassinari @minaairsupport

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 6, 2020

Sorry, we are not really interested in the developer's use case for this. What's the motivation from an end-user perspective?

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Feb 6, 2020
@watkinshughes
Copy link

The use case for our team for this same feature request would be to disable the filter until x number of characters are typed by the end user...thus limiting the distraction of the combo box until the list is filtered by at least a certain number of characters.

@oliviertassinari oliviertassinari changed the title AutoComplete - Start after specific number of letters [Autocomplete] Start after specific number of letters Mar 2, 2020
@oliviertassinari oliviertassinari added new feature New feature or request and removed status: waiting for author Issue with insufficient information labels Mar 2, 2020
@oliviertassinari

This comment has been minimized.

@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Mar 2, 2020
@watkinshughes
Copy link

Nice, thank you! Will see if I can get some time set aside for working on a PR.

@netochaves
Copy link
Contributor

Can I work on this?

@oliviertassinari

This comment has been minimized.

@CyanoFresh
Copy link
Contributor

maybe add another noOptions message when startAfter provided? Something like `Type 1 more character to search'

@oliviertassinari
Copy link
Member

@CyanoFresh We won't fix it in the library, but feel free to share your solution to the problem, it could help others.

@oliviertassinari oliviertassinari added waiting for 👍 Waiting for upvotes and removed ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request waiting for 👍 Waiting for upvotes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants