Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BreadcrumbsCollapse] Page scrolling down on Space press when button is in focus #19783

Closed
2 tasks done
captain-yossarian opened this issue Feb 19, 2020 · 2 comments
Closed
2 tasks done

[BreadcrumbsCollapse] Page scrolling down on Space press when button is in focus #19783

captain-yossarian opened this issue Feb 19, 2020 · 2 comments
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information

Comments

@captain-yossarian
Copy link
Contributor

captain-yossarian commented Feb 19, 2020 •
edited
Loading

  • The issue will appear after this PR
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Page is scrolling down, when ButtonBase component is in focus and Space bar is pressed

Expected Behavior 🤔

Page should not scroll at all

Steps to Reproduce 🕹

Steps:

  1. Go to Collapsed breadcrumbs - docs
  2. Press inside rectangle
    material1
  3. Press twice "Tab"
    Expand button (the one with 3 dots) should be in focus
    material2
  4. Press "Space"

Context 🔦

This PR should be merged after #19724
Please see this comment

Your Environment 🌎

Tech Version
Material-UI v4.?.?
React 16
Browser Chrome
TypeScript
etc.
@captain-yossarian captain-yossarian changed the title [Breadcrumbs] Page scrolling down on Space press and button in focus [ButtonBase] Page scrolling down on Space press and button in focus Feb 19, 2020
@captain-yossarian captain-yossarian mentioned this issue Feb 19, 2020
Merged
1 task
@captain-yossarian captain-yossarian changed the title [ButtonBase] Page scrolling down on Space press and button in focus [ButtonBase] Page scrolling down on Space press when button is in focus Feb 19, 2020
@eps1lon
Copy link
Member

eps1lon commented Feb 19, 2020

Breadcrumbs collapsed is not using a ButtonBase. This issue is unrelated to ButtonBase.

@eps1lon eps1lon added the status: waiting for author Issue with insufficient information label Feb 19, 2020
@eps1lon eps1lon changed the title [ButtonBase] Page scrolling down on Space press when button is in focus [BreadcrumbsCollapse] Page scrolling down on Space press when button is in focus Feb 19, 2020
@captain-yossarian
Copy link
Contributor Author

captain-yossarian commented Feb 20, 2020 •
edited
Loading

@oliviertassinari Please read my description. It will after next release

@oliviertassinari oliviertassinari added the component: breadcrumbs This is the name of the generic UI component, not the React module! label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @eps1lon @captain-yossarian