Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add color sample to Default Theme docs page #20077

Closed
1 task done
mlizchap opened this issue Mar 11, 2020 · 1 comment · Fixed by #20082
Closed
1 task done

[Docs] Add color sample to Default Theme docs page #20077

mlizchap opened this issue Mar 11, 2020 · 1 comment · Fixed by #20082
Labels
docs Improvements or additions to the documentation

Comments

@mlizchap
Copy link
Contributor

I think it would be helpful to have a sample of the default theme colors in it's docs page.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Examples 🌈

Currently the docs just have the hex code with no preview of the color:
Screen Shot 2020-03-11 at 2 27 42 PM

I think it would be helpful to have a preview like they do in code editors such as VS code:
Screen Shot 2020-03-11 at 2 40 11 PM

Motivation 🔦

I reference the default theme a good bit and frequently have to manually search the colors. I think this would be helpful and save time.

I'm up for working on this if the maintainers think it's a good idea.

@eps1lon
Copy link
Member

eps1lon commented Mar 11, 2020

I had a similar idea today but regarding IntelliSense in vscode 😆

But this is a great idea now that we control the full component. I guess we can check if the string would be useful as a color and then add a preview:

https://github.com/mui-org/material-ui/blob/5633c2768437604c7cfeed4eb62493c537469b19/docs/src/pages/customization/default-theme/DefaultTheme.js#L45-L46

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants