Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip] Screen reader reads out all of the chips at once #20172

Closed
2 tasks done
jcafiero opened this issue Mar 18, 2020 · 3 comments · Fixed by #20294
Closed
2 tasks done

[Chip] Screen reader reads out all of the chips at once #20172

jcafiero opened this issue Mar 18, 2020 · 3 comments · Fixed by #20294
Labels
accessibility a11y component: chip This is the name of the generic UI component, not the React module!

Comments

@jcafiero
Copy link
Contributor

jcafiero commented Mar 18, 2020

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Currently, when the screen reader moves to read a group of chips, it reads off the information within each of the chips one after the other. There is no indication given that this is a grouping or list of chips.

Also it is worth noting that the screen reader does read off the chips individually if there are certain chips with action (such as an 'x' for removal) so if a user mixes removable/plaintext chips together the screen reader experience is inconsistent.

Expected Behavior 🤔

The screen reader should take pauses between each of the chips in a group of chips. There should also be some context given as to this being a group of items, such as how lists are handled (ex: 'list item 1 of x')

Steps to Reproduce 🕹

Code Sandbox: https://codesandbox.io/s/blissful-dijkstra-650le?fontsize=14&theme=dark

Steps:

  1. Turn on screen reader (JAWS for Chrome or NVDA for Firefox) and open up the Code Sandbox link in the appropriate browser.
  2. Focus screen reader the group of chips.
  3. Note that the group of chips reads out as one long string with no indication that the chips are a part of a group of chips and no logical break between chips (as a sighted user might have with visually seeing the chips separated)

Context 🔦

With this issue present, it is difficult for users who rely on screen reader technology to take in the information being displayed in chips properly.

Your Environment 🌎

Tech Version
Material-UI v4.9.7
React latest
Browser Chrome and Firefox (latest)
Screen Reader JAWS (for Chrome) and NVDA (for Firefox) - both latest
@eps1lon eps1lon added accessibility a11y component: chip This is the name of the generic UI component, not the React module! labels Mar 18, 2020
@eps1lon
Copy link
Member

eps1lon commented Mar 18, 2020

Thanks for the detailed issue! Just wanted to let you know that this might not be adressed in v4 since we want to rework the a11y story of the Chip for v5 anyway.

That doesn't mean we wouldn't merge a fix for this though!

Just one minor request: Please use exact versions when describing your environment. latest changes over time and it might be confusing if the current behavior is no longer reproducible.

@m4theushw
Copy link
Member

Is adding role="list" and role="listitem" for items enough? We could add to the docs. I updated the codesandbox and tested it with NVDA.

@jcafiero
Copy link
Contributor Author

jcafiero commented Mar 26, 2020

Seems good to me, I think that makes it a lot easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: chip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants