Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in Popper documentation #20462

Closed
2 tasks done
mitchellstern opened this issue Apr 8, 2020 · 0 comments · Fixed by #20464
Closed
2 tasks done

Broken link in Popper documentation #20462

mitchellstern opened this issue Apr 8, 2020 · 0 comments · Fixed by #20464
Assignees
Labels
component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation

Comments

@mitchellstern
Copy link

The link to the Popper modifiers documentation on https://material-ui.com/api/popper/ is broken.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The link in the modifiers prop description points to https://github.com/FezVrasta/popper.js/blob/master/docs/_includes/popper-documentation.md#modifiers--object which is a broken link.

Expected Behavior 🤔

The link should be updated to point to the new location. Because Material-UI is using Popper.js v1.16, I believe this should be one of the following:

Steps to Reproduce 🕹

Steps:

  1. Navigate to https://material-ui.com/api/popper/#props.
  2. Click the link with text 'read the modifiers documentation' in the modifiers prop description.
@eps1lon eps1lon self-assigned this Apr 8, 2020
@eps1lon eps1lon added component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation labels Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants