-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Keep the same header between locales #20829
Comments
@jaironalves Thanks, regarding the implementation, it would require to:
Done |
Note that using the id from another translation can break if the translations aren't synced. It's not ideal for the master deploy but manageable. We just need to make sure that we never deploy outdated translations to |
@eps1lon Great point. Depending on the level of quality we want to provide on the translations, we could either fail or fallback to the translated hash. Maybe the latter? Crowdin guarantees that it will be eventually kept in sync. |
That is hardly a useful guarantee. When is "eventually"? |
@eps1lon The "when" depends on the frequency we merge the changes into the repository. I think that it can be automated. Right now, it's every time we manually do it. For instance, once per release. |
That's what I was saying: It's not as important if they're out-of-sync on |
Intention
Regardless of how the translation affects the content, it should not affect the anchor (#) that keeps pointing to the content.
Summary 💡
The request is that the translations keep the same header, facilitating the way the links are made available between locales.
Currently when a content is translated, the anchor for this content also changes, resulting in the scenario below.
Examples 🌈
https://material-ui.com/components/rating/#simple-ratings
https://material-ui.com/zh/components/rating/#%E7%AE%80%E5%8D%95%E8%AF%84%E5%88%86
Expected
Regardless of locale, same content anchor #
https://material-ui.com/components/rating/#simple-ratings
https://material-ui.com/zh/components/rating/#simple-ratings
https://material-ui.com/pt/components/rating/#simple-ratings
Motivation 🔦
Discussion started on this pull request #20779.
The text was updated successfully, but these errors were encountered: