Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueLabelComponent not working in Vertical Slider #21721

Closed
2 tasks done
mishra-prabhakar opened this issue Jul 8, 2020 · 3 comments
Closed
2 tasks done

ValueLabelComponent not working in Vertical Slider #21721

mishra-prabhakar opened this issue Jul 8, 2020 · 3 comments
Labels
component: slider This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@mishra-prabhakar
Copy link

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The thumb component is broken and the value label sticks at the top.

Expected Behavior 🤔

Thumb should be visible and clickable.
Value label should follow the thumb click/slide.

Steps to Reproduce 🕹

Codesandbox: https://codesandbox.io/s/material-demo-us8ni

Steps:

  1. Click on the thumb
  2. There should see an error

Context 🔦

I am trying to build a custom vertical slider with custom ValueLabelComponent.
image

Your Environment 🌎

Tech Version
Material-UI v4.11
React 16.3
Browser Chrome, Firefox
@mishra-prabhakar mishra-prabhakar added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 8, 2020
@joshwooding
Copy link
Member

You need to match the API of the ValueLabel component and render children.

There's an example in the customized sliders section
GitHub source: https://github.com/mui-org/material-ui/blob/master/docs/src/pages/components/slider/CustomizedSlider.js#L17

@joshwooding
Copy link
Member

@oliviertassinari Do you think we need to add more docs for this?

@oliviertassinari oliviertassinari added the component: slider This is the name of the generic UI component, not the React module! label Jul 9, 2020
@oliviertassinari
Copy link
Member

@joshwooding At least, we plan to refactor this part in #17905

@oliviertassinari oliviertassinari added new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants