Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.11.0][Breakpoints]Breakpoints between method provides wrong value for widest screen value #23307

Closed
1 of 2 tasks
smoleniuch opened this issue Oct 29, 2020 · 3 comments
Closed
1 of 2 tasks

[4.11.0][Breakpoints]Breakpoints between method provides wrong value for widest screen value #23307

smoleniuch opened this issue Oct 29, 2020 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@smoleniuch
Copy link

smoleniuch commented Oct 29, 2020 •
edited
Loading

Media query generated by theme.breakpoints.between() are invalid.
Error occurs only when second parameter is widest value.In default theme it is theme.breakpoints.between('sm','xl')

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Method does not generate media query for widest media screen

Expected Behavior 🤔

Generate media query for widest screen

Steps to Reproduce 🕹

Codesandbox

Context 🔦

Your Environment 🌎

This issue does not occur on latest version of material-ui.Should this be fixed in 4.11.0 version? i would like to fix this if its even in consideration.
Thanks

Tech Version
Material-UI 4.11.0
@smoleniuch smoleniuch added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 29, 2020
@oliviertassinari
Copy link
Member

This issue does not occur on latest version of material-ui

Do you mean it was fixed in v5? We can close if it's the case. We only backport major fixes.

@oliviertassinari oliviertassinari removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 29, 2020
@oliviertassinari
Copy link
Member

Yeah OK, it's fixed in v5, we can't fix it in v4, it would be a breaking change.

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Oct 29, 2020
@oliviertassinari
Copy link
Member

Duplicate of #13448

@oliviertassinari oliviertassinari marked this as a duplicate of #13448 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @smoleniuch