Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog body hides Autocomplete dropdown #2632

Closed
nlopin opened this issue Dec 22, 2015 · 5 comments · Fixed by #2634
Closed

Dialog body hides Autocomplete dropdown #2632

nlopin opened this issue Dec 22, 2015 · 5 comments · Fixed by #2634
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!

Comments

@nlopin
Copy link

nlopin commented Dec 22, 2015

I want to use an autocomplete inside the dialog. But Dialog body has overflow styles in its body:

var body = {
      padding: spacing.desktopGutter,
      overflowY: this.props.autoScrollBodyContent ? 'auto' : 'hidden',
      overflowX: 'hidden'
    };

The result of this is incorrect autocomplete control rendering.

Dropdown is under dialog footer bar

@nlopin nlopin changed the title Autocomplete dropdown is hidden in dialog Dialog body hides Autocomplete dropdown Dec 22, 2015
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 22, 2015

We should use the Popover component internally in the autocomplete. It has a built-in portal.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 22, 2015
@alitaheri
Copy link
Member

Yes, there are many issues regarding this. Using popover for this will solve many issues 😁

@alitaheri alitaheri added this to the 0.14.0 Release milestone Dec 22, 2015
@oliviertassinari
Copy link
Member

@subjectix You want to fix it before v0.14.0?

@alitaheri
Copy link
Member

yes absolutely! it's a regression

@alitaheri
Copy link
Member

I'm working on it. don't touch it 😁 😁

@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! component: autocomplete This is the name of the generic UI component, not the React module! labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants