Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpage] EDIT THIS PAGE Button URL not working #28370

Closed
2 tasks done
PabloLION opened this issue Sep 15, 2021 · 3 comments
Closed
2 tasks done

[webpage] EDIT THIS PAGE Button URL not working #28370

PabloLION opened this issue Sep 15, 2021 · 3 comments
Labels
duplicate This issue or pull request already exists v4.x

Comments

@PabloLION
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

EDIT THIS PAGE button onClick will open a new URL which gives a 404.

Expected Behavior 🤔

EDIT THIS PAGE button onClick can direct users correctly

Steps to Reproduce 🕹

Steps:

  1. Go to Paper API page or Card API page
  2. (Set language to ENGLISH) Click the EDIT THIS PAGE button in top part of the page body.

Context 🔦

I'm trying to add a line like this to Porps Chapter:

variant | 'elevation'\| 'outlined' | 'elevation' | The variant to use.
-- | -- | -- | --

Idea on fixing this bug

  • It seems you are using JSON for the webpages(maybe), so I made a PR Update card.json #28369. I'm not so certain because I didn't see sx in Props.
  • The handicup is that editing JSON may not be very similar to editing an HTML, also it's hard to see the edit before PR. In my case I just did a copy paste so it should be correct.
  • Here's the Workaround I propose: temporarily remove/disable the EDIT THIS PAGE button

Your Environment 🌎

Chrome 91

@PabloLION PabloLION added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 15, 2021
@PabloLION
Copy link
Contributor Author

PabloLION commented Sep 15, 2021

If you approve this work-around. I would make a new PR on components/ApiPage.js

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 15, 2021

It's similar to #28345, but it's actually a duplicate of #23406 this time, we fixed the root cause in #23821. I'm closing since it impacts a legacy version (v4).

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer docs Improvements or additions to the documentation labels Sep 15, 2021
@PabloLION
Copy link
Contributor Author

I didn't search across closed PRs. Sorry for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists v4.x
Projects
None yet
Development

No branches or pull requests

2 participants