Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onShow not called if openImmediately #287

Closed
wavded opened this issue Jan 29, 2015 · 1 comment
Closed

onShow not called if openImmediately #287

wavded opened this issue Jan 29, 2015 · 1 comment
Labels
component: dialog This is the name of the generic UI component, not the React module!

Comments

@wavded
Copy link

wavded commented Jan 29, 2015

Given:

      <Dialog
        ref="dialog"
        openImmediately={true}
        title="Get started"
        onShow={this.onShow} />

this.onShow isn't called when the component is loaded. It is called if I manually call this.refs.dialog.show().
@jkruder jkruder mentioned this issue Mar 21, 2015
Merged
@mmrtnz
Copy link
Contributor

mmrtnz commented Mar 23, 2015

Fixed with #453

@mmrtnz mmrtnz closed this as completed Mar 23, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: dialog This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wavded @oliviertassinari @mmrtnz @zannager