Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Adjust Base demos for dark mode #30806

Closed
michaldudak opened this issue Jan 27, 2022 · 2 comments · Fixed by #30884
Closed

[docs] Adjust Base demos for dark mode #30806

michaldudak opened this issue Jan 27, 2022 · 2 comments · Fixed by #30884
Labels
docs Improvements or additions to the documentation

Comments

@michaldudak
Copy link
Member

As pointed out in #30113 (comment), some of the unstyled demos don't look right under dark mode. This issue is meant to track work related to updating all the unstyled demos so they look great in both light and dark modes.

@michaldudak michaldudak added the docs Improvements or additions to the documentation label Jan 27, 2022
@michaldudak michaldudak self-assigned this Jan 27, 2022
@michaldudak michaldudak moved this to To do 📃 in Base UI Alpha Jan 27, 2022
@michaldudak michaldudak moved this from To do 📃 to In progress 🛠 in Base UI Alpha Jan 27, 2022
@danilo-leal
Copy link
Contributor

Hey! Does it make sense to have an umbrella issue for this task? I think we should have the demos looking great as part of any component PR, not merging it before the documentation for it is good enough. As far as I can see, Select is the only one right now in need of a little tweak (maybe a bit the inactive Switch as well) on dark mode but all the other ones are mostly fine. Do you have anything else in mind?

@michaldudak
Copy link
Member Author

Let's update Select and Switch demos as a part of this issue then and make sure in the future that dark mode demos look well before merging, as you suggest.

Repository owner moved this from In progress 🛠 to Done 🎉 in Base UI Alpha Feb 10, 2022
@michaldudak michaldudak removed their assignment May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants