Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] No defaultValue or value for this component? #3178

Closed
darky opened this issue Feb 4, 2016 · 9 comments
Closed

[AutoComplete] No defaultValue or value for this component? #3178

darky opened this issue Feb 4, 2016 · 9 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@darky
Copy link

darky commented Feb 4, 2016

No description provided.

@darky
Copy link
Author

darky commented Feb 4, 2016

Finded, searchText attr

@darky darky closed this as completed Feb 4, 2016
@oliviertassinari
Copy link
Member

@alitaheri Aside from the callback standardization #2957, iI think that it would be good to standardize the value and defaultValue properties.

@alitaheri
Copy link
Member

@oliviertassinari We should get rid of defaultValue actually. and only use value. so that the Wrapper can have defaultValue for it's state 😁

@oliviertassinari
Copy link
Member

I agree (#2784). But the wrapper would have a defaultValue property right 😁?

@alitaheri
Copy link
Member

But the wrapper would have a defaultValue property right 😁?

Indeed ^_^

@neopostmodern
Copy link

Could you maybe already now add a note to the docs stating something amongst the lines of

defaultValue: Use searchText instead.

?

@oliviertassinari
Copy link
Member

@neopostmodern Yes, we could. This searchText is definitly not standard across the react community.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2016

Actually, I think that we should go one step further by renaming the searchText property to value.

@oliviertassinari oliviertassinari changed the title [AutoComplete Auto complete] No defaultValue or value for this component? [AutoComplete] No defaultValue or value for this component? Sep 18, 2016
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 18, 2016

I'm closing this issue in favor of #5062. Thanks for raising it.

@zannager zannager added the component: autocomplete This is the name of the generic UI component, not the React module! label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants