Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skeleton] Built in support for delayed appearance #34057

Open
2 tasks done
oliviertassinari opened this issue Aug 24, 2022 · 0 comments
Open
2 tasks done

[Skeleton] Built in support for delayed appearance #34057

oliviertassinari opened this issue Aug 24, 2022 · 0 comments
Labels
component: skeleton This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer new feature New feature or request waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 24, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

This issue is meant to discuss the need for a built-in support for delaying the appearance of a skeleton.

Examples 🌈

You can find an example in https://mui.com/material-ui/react-progress/#delaying-appearance.

Motivation 🔦

With @DanailH, I believe that we have found a valid use case for delaying the appearance of the skeleton within a data grid: mui/mui-x#5214 (comment). In some cases, the rows of the data grid load so fast that we see a flash of a skeleton. It might be better to delay the appearance of the skeleton to only the cases where the data is slow to load. For instance, when loading the rows in Notion, you never see a skeleton, only a while background.

So, I wonder if it makes sense to add a prop to have this behavior built-in in MUI Core.

In the case of the data grid, there is another dimension to consider that could help with the problem: overs canning (loading rows outside of the viewport in anticipation). But even with this, I think that this issue is still relevant.

cc @gerdadesign

@oliviertassinari oliviertassinari added new feature New feature or request component: skeleton This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer waiting for 👍 Waiting for upvotes labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: skeleton This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer new feature New feature or request waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

1 participant