Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require(ing) individual components #363

Closed
gilbox opened this issue Feb 24, 2015 · 2 comments · Fixed by #588
Closed

require(ing) individual components #363

gilbox opened this issue Feb 24, 2015 · 2 comments · Fixed by #588
Labels
component: checkbox This is the name of the generic UI component, not the React module!

Comments

@gilbox
Copy link

gilbox commented Feb 24, 2015

Did y'all consider doing this

var Checkbox = require('material-ui/Checkbox');
var EnhancedButton = require('material-ui/EnhancedButton');

instead of

var {Checkbox, EnhancedButton) = require('material-ui');

??

Seems that with this type of library you shouldn't be importing the pieces you don't need.

@RamIdeas
Copy link

👍

@hai-cea
Copy link
Member

hai-cea commented Feb 25, 2015

Yep - totally agree. We're working on moving styles into the js and I imagine we'll be able to reorganize the files at the same time.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: checkbox This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkbox This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants