Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnTouchTap events with React v0.15-RC1 #3634

Closed
Mythra opened this issue Mar 8, 2016 · 1 comment
Closed

OnTouchTap events with React v0.15-RC1 #3634

Mythra opened this issue Mar 8, 2016 · 1 comment
Labels
core Infrastructure work going on behind the scenes

Comments

@Mythra
Copy link

Mythra commented Mar 8, 2016

Problem Description

The select field doesn't dropdown as soon as we upgraded to React v0.15-RC1. Now we don't use any other onTouchTap items in our code so it's possible this affects any on touch tap items.

Versions

  • Material-UI: 0.15.0-alpha.1
  • React: 15.0.0-rc.1
  • Browser:
    Firefox: 44.0.2 Mac OS X,
    Firefox: 45.0 Mac OS X,
    Chrome: Version 48.0.2564.116 Mac OS X,
    Chrome: 49.0.2623.75 Mac OS X

Console Log Output that is probably relevant:

Warning: NavigationArrowDropDown: `key` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop. (https://fb.me/react-special-props)

Relevant Code:

import { PropTypes, Component } from 'react';
import injectTapEventPlugin from 'react-tap-event-plugin';
injectTapEventPlugin();

export default class FieldTest extends Component {
  constructor(props) {
    super(props);
  }

  _renderOptions = () => {
     return this.props.options.map( (value, name) => {
      return (
        <MenuItem value={value} key={name} primaryText={name} />
      );
    });
  }

  render() {
     return (
      <SelectField {...this.props}>
        {this._renderOptions()}
      </SelectField>
    );
  }
}

Which ends up being rendered with something like:

<FieldTest props={{ Open: "open", On Hold: "on hold", Pending: "pending", Solved: "solved" }} />
@Mythra
Copy link
Author

Mythra commented Mar 9, 2016

Actually this has been reported here: facebook/react#6221

React v0.15 problem. Closing.

@Mythra Mythra closed this as completed Mar 9, 2016
@zannager zannager added the core Infrastructure work going on behind the scenes label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

No branches or pull requests

2 participants