Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Make OverridableComponentAugmentation default #41229

Open
oliviertassinari opened this issue Feb 22, 2024 · 2 comments
Open

[types] Make OverridableComponentAugmentation default #41229

oliviertassinari opened this issue Feb 22, 2024 · 2 comments

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 22, 2024

Steps to reproduce

#19113 (comment)

Search keywords: OverridableComponentAugmentation

@oliviertassinari oliviertassinari added breaking change typescript status: waiting for maintainer These issues haven't been looked at yet by a maintainer v6.x labels Feb 22, 2024
@oliviertassinari oliviertassinari added this to the Material UI: v6 milestone Feb 22, 2024
@oliviertassinari oliviertassinari removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 22, 2024
@mnajdova mnajdova self-assigned this Feb 22, 2024
@mnajdova
Copy link
Member

I postponed this effort because we were looking into whether we should do an overhaul of the TypeScript improvements. Since that was postponed, I am wondering whether it makes sense to introduce this now, considering it will be a non-trivial breaking changes, because lots of the ref's usages will need to be cast. @DiegoAndai, @siriwatknp what are your thoughts? If you are ok with this change, I can apply the changes and update our internal usages.

@DiegoAndai
Copy link
Member

DiegoAndai commented Jul 30, 2024

considering it will be a non-trivial breaking changes, because lots of the ref's usages will need to be cast

  • What would the breaking changes look like?
  • Do we know how many users are using import type {} from '@mui/material/OverridableComponentAugmentation';?
  • How much of a performance improvement is it?

@mnajdova

@DiegoAndai DiegoAndai removed this from the Material UI: v6 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants