[code-infra] Replace all references of event as e

[Janpot]

For example

material-ui/docs/data/joy/components/list/ExampleNavigationMenu.tsx

Line 67 in 1103320

onKeyDown: (e: React.KeyboardEvent<HTMLAnchorElement>) => {

Also enforce this with an eslint rule. e.g. https://eslint.org/docs/latest/rules/id-length https://eslint.org/docs/latest/rules/id-denylist

Single letter identifiers are desired in some cases (t for translations, and i, j, k for loop variables). So let's keep the scope of this issue down to specific identifiers only and not enforce it by length. Some other ids I can think of are:

• err => error
• res => response, or did you mean result, or resolve?
• ?

[danilo-leal]

I've also seen somewhat similar stuff with t being used for translation:

material-ui/docs/data/material/components/material-icons/SearchIcons.js

Line 263 in 6577056

const t = useTranslate();

Should we think of it similarly?

[Janpot]

Maybe, it's up to the core team IMO. I think we're all quite on the same page for e=>event

I found this issue back in the GitHub project I'm trying to revive for code-infra. Maybe we should groom this a bit first

[flaviendelangle]

The one-letter variables are a never-ending topic in software development 😆

For e => event, it enforces some consistency across the codebase so I'm all in favor of doing it.

IMHO the rule should not apply to for loops for (let i=0), and for map / filter it's debatable but I don't have a strong preference.

[Janpot]

I agree. Ok, I propose then to keep the scope of this issue to e => event only. And to instead use the id-denylist rule. wdyt?

[AfaqShuaib09]

Hey, Could someone this issue to me? I would love to make a PR on this issue
Thanks

[Janpot]

@AfaqShuaib09 Go for it