Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Deprecate system props #42259

Open
3 of 4 tasks
siriwatknp opened this issue May 16, 2024 · 4 comments
Open
3 of 4 tasks

[material-ui] Deprecate system props #42259

siriwatknp opened this issue May 16, 2024 · 4 comments
Assignees
Labels
component: Box The React component. component: link This is the name of the generic UI component, not the React module! component: Stack The React component. component: Typography The React component. deprecation New deprecation message package: material-ui Specific to @mui/material package: system Specific to @mui/system

Comments

@siriwatknp
Copy link
Member

siriwatknp commented May 16, 2024

The RFC #41539

Search keywords:

@siriwatknp siriwatknp self-assigned this May 16, 2024
@siriwatknp siriwatknp converted this from a draft issue May 16, 2024
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 16, 2024
@siriwatknp siriwatknp added enhancement This is not a bug, nor a new feature component: Typography The React component. component: link This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material component: Box The React component. component: Stack The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 16, 2024
@siriwatknp siriwatknp added this to the Material UI: v6 milestone May 16, 2024
@DiegoAndai DiegoAndai moved this from Selected to In progress in Material UI May 24, 2024
@oliviertassinari oliviertassinari added package: system Specific to @mui/system deprecation New deprecation message and removed enhancement This is not a bug, nor a new feature labels May 30, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Material UI Jun 5, 2024
@maapteh
Copy link

maapteh commented Nov 18, 2024

@siriwatknp is it for material ui maybe nice to support eslint rules which gives a warning when having something which will break in a next major? For example React Query has an own plugin where you can set the options like "@tanstack/query/no-deprecated-options": "error",. It creates a far nicer DX since most of the libs i will not check weekly for all updates paths or RFC's.

@Darksoulsong
Copy link

@siriwatknp Hi, I'm having trouble determining which "system props" are being deprecated. Could you help me with this?

Based on the packages/mui-codemod/src/v6.0.0/system-props/removeSystemProps.js file, can I conclude that all the props listed in defaultSxConfig should no longer be used as component props but instead with the sx prop?

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 27, 2024

@maapteh Right, I'm reopening, I see that we have one of the checkboxes unticked:

SCR-20241127-okxy

can I conclude that all the props listed in defaultSxConfig should no longer be used as component props but instead with the sx prop?

@Darksoulsong I believe this was the intent, yes.

@siriwatknp
Copy link
Member Author

@siriwatknp Hi, I'm having trouble determining which "system props" are being deprecated. Could you help me with this?

Based on the packages/mui-codemod/src/v6.0.0/system-props/removeSystemProps.js file, can I conclude that all the props listed in defaultSxConfig should no longer be used as component props but instead with the sx prop?

That's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Box The React component. component: link This is the name of the generic UI component, not the React module! component: Stack The React component. component: Typography The React component. deprecation New deprecation message package: material-ui Specific to @mui/material package: system Specific to @mui/system
Projects
Status: Done
Development

No branches or pull requests

4 participants