-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LinearProgress] VERY expensive (50% CPU usage for 1 instance) #4412
Comments
@matthewoates 13" By any chance? What is your CPU like when you do a google hangout w/ video? |
@matthewoates (Not saying this isn't an issue -- just trying to gauge the level of impact relative to other apps I find make the retina MBPs without dedicated graphics go crazy) |
materializecss is even worse: @matthewoates Performant linear progress, where art thou? 😄 |
@matthewoates Polymer's is best for me so far: https://elements.polymer-project.org/elements/paper-progress?view=demo:demo/index.html&active=paper-progress |
They are using transform: https://github.com/PolymerElements/paper-progress/blob/master/paper-progress.html |
@nathanmarks : thanks for diving into this head first!
Yes, my MBP has a dedicated graphics card. Forgive me if the team is already aware of this, but I found a good Google IO talk about the various expenses of css transforms and other DOM manipulations. https://www.youtube.com/watch?v=thNyy5eYfbc I think modeling the Linear-Progress component after Polymer's implementation would be great. |
@matthewoates No worries! I'll definitely check that video out. Do you fancy having a go at trying out the transform technique instead? |
@matthewoates Nice to see that I'm not alone with my issues -- but you should see what happens on the internet with the 13" and no dedicated graphics card! 😄 |
Yeah, I'm definitely interested. I'll have time to tackle this next week. |
The performance looks better on the PolymerMaterial-UI |
Problem description
50% CPU usage on a new Retina MBP on the demo page with 2 progress indicators (only 1 of which is animating)
http://www.material-ui.com/#/components/linear-progress
By contrast, here's a page with 10 different active animations running and much lower CPU usage. (10%)
http://kyleamathews.github.io/react-spinkit/
The component looks great, but sadly In it's current state
linear-progress
is unusable.Steps to reproduce
Visit http://www.material-ui.com/#/components/linear-progress and open the chrome task manager. (top right hamburger -> more tools -> task manager
Versions
The text was updated successfully, but these errors were encountered: