Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolbar] display:flex is not a string, but an object #4417

Closed
create-renegr opened this issue Jun 3, 2016 · 4 comments
Closed

[Toolbar] display:flex is not a string, but an object #4417

create-renegr opened this issue Jun 3, 2016 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@create-renegr
Copy link

Problem description

display:flex is an object, instead of a string. Which breaks the flow of the UI. Any idea why? In the example of the documentation flex is a string.

display_not_string

Versions

  • Material-UI: 0.15.0
  • React: 15.0.1
  • Browser: Chromium 50.0
@hathawsh
Copy link

I've traced this problem to inline-style-prefixer, a package material-ui depends on. inline-style-prefixer rewrites styles based on user-agent detection and fails to detect Chromium correctly. The following code, added to any material-ui app and tested in Chromium, demonstrates that inline-style-prefixer generates a list rather than a string:

import Prefixer from 'inline-style-prefixer';
console.log(new Prefixer().prefix({display: 'flex'}).display);

@create-renegr
Copy link
Author

It appears to me, that a fix has been merged into inline-style-prefixer (see robinweser/inline-style-prefixer#84). But at the time of writing, there is no new release published. (Bugfix merged after 1.0.4 release)

So we have to wait for a new release for inline-style-prefixer. Right?

@angelikatyborska
Copy link

I have just created a pull request #4613 that updates inline-style-prefixer to the newest (2.0.0) release, but that did not solve this issue for me. The code @hathawsh provided still returns a list in Chromium (Version 51.0.2704.79 Ubuntu 14.04 64-bit).

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari
Copy link
Member

Closing as a duplicate of #5052.

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants