Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple is not centered for a radio button when using an image for the custom icon #4448

Closed
joshunger opened this issue Jun 7, 2016 · 1 comment
Labels
component: button This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. v0.x

Comments

@joshunger
Copy link

Problem description

The ripple is not centered for a radio button when using an image for the custom icon

Steps to reproduce

const style = {
  img: {
    outline: '1px solid #646e7c',
    //padding: '4px',
    border: '4px solid transparent',
    width: '40px',
    height: '40px'
  },
  radioButtonStyle:
  {
    width: '40px',
    height: '40px',
    display: 'inline-block'
  }
};

            <RadioButton
              value=""
              label=""
              checkedIcon={<img style={style.img} src={require('./placeholder-36x36.png')} />}
              uncheckedIcon={<img style={style.img} src={require('./placeholder-36x36.png')} />}
              style={style.radioButtonStyle}
              iconStyle={{width: '40px', height: '40px'}}
              inputStyle={{width: '40px', height: '40px'}}
            />

Versions

  • Material-UI: 0.15.0
  • React: 15.0.2
  • Browser: Google Chrome 50

EXPECTING: I'm expecting it to be centered or positioned at the click coordinates.

ACTUAL: Always in the bottom right area.

Is there a way to fix this?

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari
Copy link
Member

We have been porting the component on the next branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: button This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! v0.x package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. v0.x
Projects
None yet
Development

No branches or pull requests

3 participants