Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CardHeader] paddingRight: 90px #4695

Closed
Taakn opened this issue Jul 12, 2016 · 4 comments
Closed

[CardHeader] paddingRight: 90px #4695

Taakn opened this issue Jul 12, 2016 · 4 comments
Labels
component: card This is the name of the generic UI component, not the React module!

Comments

@Taakn
Copy link

Taakn commented Jul 12, 2016

Problem description

Hello,

Seems a little strange that padding right is set to 90px on CardHeader... Why is that? Kinda messes up the title on small screens. It can be overridden by textStyle so not a big problem

Thanks

Steps to reproduce

https://github.com/callemall/material-ui/blob/ec24c136a3a603d74e490e96edcd0c47b7c56680/src/Card/CardHeader.js

Versions

  • Material-UI:
  • React:
  • Browser:
@aahan96
Copy link
Contributor

aahan96 commented Jul 14, 2016

@Taakn Have you checked how removing the padding affects small screens? It doesn't affect the desktops, as far as I have looked into it

@Taakn
Copy link
Author

Taakn commented Jul 17, 2016

@aahan96 For me removing the padding on small screens works fine. For desktop that doesn't cause any issues either way.

@aahan96
Copy link
Contributor

aahan96 commented Jul 19, 2016

Okay, let me create a PR for it

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari oliviertassinari added the component: card This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member

The padding-right has proven to be necessary. I'm closing the issue.
Plus, the next branch is now using the flexbox layout engine. We do no longer use that padding hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants