-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar] Inline Chips size ignored. #4849
Comments
Ok, solution turns out to be very simple:
|
I think adding a new prop Although it would need a |
@BlockChange You are right. I think that we should consider it a bug, at this line. I'm not sure to understand your use case for the inline stuff. Do you have a visual explanation? |
Problem seems solved, this should be closed |
I'm going to close the issue. Things aren't perfect but the pain point seem addressed. |
@oliviertassinari Although the post talks about "inline" chip styles. The real issue for this ticket should be the Avatar size prop in Chips is currently hard coded at 32. Therefore you can't pass down a size prop from Avatar when its used within. This needs to be fixed as when a chip is styled to be smaller, the avatar shouldn't remain at 32, it should take the prop that is being passed down. That line should be |
@peterpuzos Yes, I think that you are right! Do you want to submit a PR with that fix and the corresponding test? |
When I override the style for a chip to
display: inline
, it will shrinks the right side to the height of the text.<Chip style={{ display: 'inline' }} ><Avatar size={23} src="/images/logos/logo.png" />{name}</Chip>
I was going to compromize by setting the
Avatar
size prop, but it gets overridden by the chip it seems.(Mui 0.15.2)
The text was updated successfully, but these errors were encountered: