Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableBody] passes [null] as children to children it clones #4881

Closed
dantman opened this issue Aug 3, 2016 · 1 comment
Closed

[TableBody] passes [null] as children to children it clones #4881

dantman opened this issue Aug 3, 2016 · 1 comment
Labels
component: table This is the name of the generic UI component, not the React module!

Comments

@dantman
Copy link
Contributor

dantman commented Aug 3, 2016

I've been having performance issues with a Table+RadioButton combination, so I was attempting to improve performance by wrapping my TableRow elements in a pure component.

However I discovered that TableBody clones the component I pass to it and calls it in a way that causes [null] to be passed as children to the component.

Since the array object containing null is different each time, this results in standard pure components never acting pure when passed to TableBody.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari oliviertassinari added the component: table This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari oliviertassinari changed the title TableBody passes [null] as children to children it clones [TableBody] passes [null] as children to children it clones Dec 18, 2016
@oliviertassinari
Copy link
Member

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants