Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] can be dismissed at any time (even the millisecond that it is shown) #506

Closed
matthewoates opened this issue Apr 6, 2015 · 1 comment
Labels
component: dialog This is the name of the generic UI component, not the React module!

Comments

@matthewoates
Copy link
Contributor

This is an issue that I have noticed with dialogs in other phone apps.

If the app is highly interactive, the user may try to click/tap on something the instant this dialog is shown. They likely will not have time to read what the dialog said because their click will have dismissed it.

This can be resolved by ignoring dismiss actions for a configurable amount of time. This also addresses another request of mine which was to be able to create dialogs which cannot be dismissed. (this can be done by just passing in a large number/Infinity.

@matthewoates matthewoates changed the title no way to keep Dialog open no way to prevent Dialog from being dismissed Apr 6, 2015
@matthewoates matthewoates changed the title no way to prevent Dialog from being dismissed Dialog can be dismissed at any time (even the millisecond that it is shown) Apr 10, 2015
@jkruder
Copy link
Contributor

jkruder commented Apr 10, 2015

PR #523 allows for modal dialogs which addresses part of your concern. Should not be difficult to put a timer of some sort to ignore clicks. However, I would suggest that this not be configurable or have a max limit as it is not appropriate to use a time to create a modal dialog.

@hai-cea hai-cea changed the title Dialog can be dismissed at any time (even the millisecond that it is shown) [Dialog] can be dismissed at any time (even the millisecond that it is shown) Jun 18, 2015
@zannager zannager added the component: dialog This is the name of the generic UI component, not the React module! label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants