Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Unselect / Toggle select is not visually working (background remains) #9569

Closed
caub opened this issue Dec 20, 2017 · 1 comment
Closed
Labels
component: select This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@caub
Copy link
Contributor

caub commented Dec 20, 2017

Steps to Reproduce (for bugs)

https://codesandbox.io/s/7jox7jylj6

  • select a value
  • click it again, to unselect it
  • then the option doesn't lose the selected background until the select menu is closed and reopened

So we can't know if we have unselect it

Expected Behavior

It should toggle selection on a item after each click

This happens with multiple option at least

edit: actually the font-weight is slightly changing (400 / 500), but I believe this background should be cleared is the pointer leaves hover, I guess there's an :active rule that still make it with this background

Current Behavior

Unselected items stay visually selected

Your Environment

Tech Version
Material-UI 1.0.0-beta.24
React 16.2.0
browser chrome, firefox
@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists labels Dec 20, 2017
@oliviertassinari
Copy link
Member

then the option doesn't lose the selected background until the select menu is closed and reopened

Duplicate of #5186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants