[Performance] MouseOver/MouseOut -> MouseEnter/MouseLeave #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves performances by not handling child events. This avoid glitches. For example in ListItem with the former code, the event was called each time the mouse was over a child, generating a lot of false positive.
|
it needs review. I removed did not remove mouseout/mouseover of menu as it seemed useful. |
cgestes
changed the title
do not rerender when hoverColor is not set.
|
@cgestes Thanks for this PR! It looks good to me. |
hai-cea
pushed a commit
that referenced
this pull request
Jul 17, 2015
[Performance] MouseOver/MouseOut -> MouseEnter/MouseLeave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performances by not handling child events.
This avoid glitches. For example in ListItem with the former code, the event was called each time the mouse was over a child, generating a lot of false positive.