-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectInput] Fix layout issue with displayEmpty #16743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: cfedbcb...44a1bc3
|
oliviertassinari
added
bug 🐛
Something doesn't work
component: select
This is the name of the generic UI component, not the React module!
labels
Jul 25, 2019
oliviertassinari
approved these changes
Jul 25, 2019
merceyz
reviewed
Jul 25, 2019
oliviertassinari
added
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
and removed
PR: good for merge
labels
Jul 25, 2019
oliviertassinari
removed
the
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
label
Jul 26, 2019
oliviertassinari
force-pushed
the
fix-empty-select-layout
branch
from
July 26, 2019 17:16
cb7e6af
to
44a1bc3
Compare
oliviertassinari
approved these changes
Jul 26, 2019
Thanks for fixing! 😃 |
merceyz
reviewed
Jul 26, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: select
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certain condition with displayEmpty is enabled, SelectInput skips zero-width space hack, leads to layout issue like below:
Conditions:
''
,' '
,'\n'
or'\t'
).multiple === true && value === []
Reproduction: