Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rating] Improve rendering of arbitrary precision #17013

Merged
merged 3 commits into from
Aug 20, 2019
Merged

[Rating] Improve rendering of arbitrary precision #17013

merged 3 commits into from
Aug 20, 2019

Conversation

Patil2099
Copy link
Contributor

@Patil2099 Patil2099 commented Aug 15, 2019

Fixes #16939

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 15, 2019

Details of bundle changes.

Comparing: 10ed7cf...0b6c17b

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 329,178 329,178 90,019 90,019
@material-ui/core/Paper 0.00% 0.00% 68,843 68,843 20,523 20,523
@material-ui/core/Paper.esm 0.00% 0.00% 62,217 62,217 19,249 19,249
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,135 2,135
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,826 5,826
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,059 1,059
@material-ui/lab +0.07% 🔺 +0.03% 🔺 153,211 153,319 46,742 46,757
@material-ui/styles 0.00% 0.00% 51,561 51,561 15,339 15,339
@material-ui/system 0.00% 0.00% 15,658 15,658 4,360 4,360
Button 0.00% 0.00% 78,847 78,847 24,093 24,093
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating +0.15% 🔺 +0.27% 🔺 70,206 70,314 21,925 21,984
Slider 0.00% 0.00% 74,539 74,539 23,108 23,108
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 53,311 53,311 13,786 13,786
docs.main 0.00% 0.00% 599,123 599,123 191,150 191,150
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 300,169 300,169 86,407 86,407

Generated by 🚫 dangerJS against 0b6c17b

@oliviertassinari oliviertassinari added component: rating This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Aug 15, 2019
@oliviertassinari oliviertassinari changed the title Wrong rendering for value of 3.9 and precision of 0.2(Fixed) [Rating] Improve rendering of arbitrary precision Aug 15, 2019
@oliviertassinari
Copy link
Member

Thanks for giving the issue a try :). I think that it's a great opportunity to add a test case for the correct behavior. Could you add one? Thanks. I might have some time, by the end of the week, otherwise.

@Patil2099
Copy link
Contributor Author

@oliviertassinari I will try to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: rating This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@material-ui/lab/Rating - wrong rendering for value of 3.9 and precision of 0.2
3 participants