Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Box] Better DX for deprecated props #23285

Merged
merged 13 commits into from
Nov 13, 2020
Merged

[Box] Better DX for deprecated props #23285

merged 13 commits into from
Nov 13, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 27, 2020 •
edited
Loading

  1. fix display name (was StyledComponent)
  2. Move deprecation to propTypes for proper component stacks
    These warnings aren't useful if only triggered once.
    They also break our test suite if we don't have the ability to reset modules.
    The approach already hid one usage of deprecated props in the test suite.
  3. Remove deprecated props from docs

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 28, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against fcbebc5

@github-actions github-actions bot mentioned this pull request Oct 28, 2020
Closed
@eps1lon eps1lon mentioned this pull request Oct 29, 2020
Merged
@eps1lon eps1lon force-pushed the fix/docs/box-deprecation branch 2 times, most recently from 63ea04e to 0788b0f Compare November 3, 2020 11:06
@oliviertassinari oliviertassinari added component: Box The React component. docs Improvements or additions to the documentation new feature New feature or request labels Nov 7, 2020
@eps1lon eps1lon mentioned this pull request Nov 12, 2020
Merged
@mbrookes mbrookes mentioned this pull request Nov 12, 2020
Merged
@eps1lon eps1lon marked this pull request as ready for review November 12, 2020 18:03
@eps1lon eps1lon merged commit 23d722d into mui:next Nov 13, 2020
@eps1lon eps1lon deleted the fix/docs/box-deprecation branch November 13, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnturner quinnturner quinnturner left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Box The React component. docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @mui-pr-bot @oliviertassinari @quinnturner