-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Joy] Add AvatarGroup
component
#31980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mui/joy: parsed: +1.23% , gzip: +0.97% |
danilo-leal
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, excellent work!
siriwatknp
commented
Mar 26, 2022
oliviertassinari
added
the
component: avatar
This is the name of the generic UI component, not the React module!
label
Mar 29, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: avatar
This is the name of the generic UI component, not the React module!
package: joy-ui
Specific to @mui/joy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥 Preview
Inspired by #31958 (comment).
Get rid of internal calculation about the number of extra to show which give developers full control of the extra number logic. This approach would reduce a lot of edge cases problem because we don't use
React.cloneElement
anymore, developers can wrap with whatever they want. Thanks to CSS variables, we don't introduce any class selector which makes customization so easy.Benefits
Joy solves these existing issues:
[AvatarGroup] Add a prop for configuring the overlap #30789
[AvatarGroup] Clickable "ellipsis" #27677
[AvatarGroup] Add the possibility to show a tooltip when using a group #31958
Benchmark