[docs] Fix en-US format in the Skeleton demo #33699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
husseinsaad98
commented
Jul 29, 2022
•
husseinsaad98
commented
- I have followed (at least) the PR section of the contributing guide.
oliviertassinari
changed the title
oliviertassinari
added
the
component: skeleton
|
Looks good, it matches with
|
oliviertassinari
changed the title
michaldudak
approved these changes
Aug 1, 2022
| @@ -9,21 +9,21 @@ const data = [ | |||
| src: 'https://i.ytimg.com/vi/pLqipJNItIo/hqdefault.jpg?sqp=-oaymwEYCNIBEHZIVfKriqkDCwgBFQAAiEIYAXAB&rs=AOn4CLBkklsyaw9FxDmMKapyBYCn9tbPNQ', | |||
| title: 'Don Diablo @ Tomorrowland Main Stage 2019 | Official…', | |||
| channel: 'Don Diablo', | |||
| views: '396 k views', | |||
| views: '396k views', | |||
There was a problem hiding this comment.
Suggested change
| views: '396k views', | |
| views: '396K views', |
@samuelsycamore Also, I wonder, shouldn't it be K instead of k?
There was a problem hiding this comment.
@oliviertassinari I would expect to see lowercase k in US English to refer to units of 1000. Uppercase K would be more common when referring to distance, i.e. running a 10K = 10-kilometer race. In the International System of Units, lowercase k denotes multiplication by 1000, whereas uppercase K refers to Kelvin (temperature unit).
There was a problem hiding this comment.
OK thanks, so we are good
(for the Kelvin, I think it's only relevant for an academic audience, I haven't used the K unit since university, but it's a unit, not a scale)
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.