IconButton FontIcon child hover styling #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troutowicz
force-pushed
the
icon_button
branch
3 times, most recently
from
a40a430 to
e8d3f4b
Compare
|
@pomerantsev Any preference on passing |
|
@troutowicz I personally prefer to have as few options as possible, so hoverColor makes more sense to me, but I guess it's better to consult the actual Material Design guidelines on whether or not any style changes should be possible on hover. |
troutowicz
force-pushed
the
icon_button
branch
2 times, most recently
from
dc32caa to
2f276a7
Compare
|
@pomerantsev Looked through the spec and it looks like hover color is the only hover style the component needs. PR has been updated. |
|
👍 |
hai-cea
pushed a commit
that referenced
this pull request
May 15, 2015
IconButton FontIcon child hover styling
|
Thanks @troutowicz & @pomerantsev 👍 |
zannager
added
the
component: icon button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a way to pass down hover style to the FontIcon child in IconButton.
Use case