Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF component #13825

Open
oliviertassinari opened this issue Jul 13, 2024 · 7 comments
Open

Add PDF component #13825

oliviertassinari opened this issue Jul 13, 2024 · 7 comments
Labels
new feature New feature or request waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 13, 2024

Summary

This feature request is made of two parts:

PDF Viewer

The ability to display PDFs directly into a web page.

PDF Editor

The ability to display and edit PDF directly into a web page.

Motivation

Public: https://mui-org.notion.site/mui-x-PDF-component-74e68291f1c84bffa2b25f3a118edecd?pvs=4
Editable: https://www.notion.so/mui-org/mui-x-PDF-component-74e68291f1c84bffa2b25f3a118edecd

Search keywords: -

@oliviertassinari oliviertassinari added new feature New feature or request status: waiting for maintainer These issues haven't been looked at yet by a maintainer waiting for 👍 Waiting for upvotes labels Jul 13, 2024
@michelengelen
Copy link
Member

michelengelen commented Jul 15, 2024

I have played with this package a while back and really liked it: https://react-pdf.org/

EDIT: just saw it in the list ... sry! :D

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 15, 2024

I have played with this package a while back

@michelengelen What was your use case to embed a PDF reader into a page?

@michelengelen
Copy link
Member

michelengelen commented Jul 15, 2024

I have played with this package a while back

@michelengelen What was your use case to embed a PDF reader into a page?

I had 2 use cases:

  1. was a simple accounting system to create invoices.
  2. was a system for football fans where they could select a player and print the infos about them in different templates.

@michelengelen
Copy link
Member

Objections adding this to the explore board @mui/x ?

@flaviendelangle
Copy link
Member

I don't think new set of components belongs to the board, it's not thing we are going to pick from the board as we would for bug fixes or new features.

@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 16, 2024
@TheOneTheOnlyJJ
Copy link

When this ships, it would be useful to print charts and data grids.

@oliviertassinari
Copy link
Member Author

@TheOneTheOnlyJJ For charts, I would see #11746 solving it, and for data grid: https://mui.com/x/react-data-grid/export/#print-export.

@oliviertassinari oliviertassinari changed the title Create PDF component Add PDF component Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

4 participants