Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove gridKeyboardMultipleKeySelector in useGridSelection #1437

Closed
1 task done
m4theushw opened this issue Apr 19, 2021 · 2 comments · Fixed by #1813
Closed
1 task done

[DataGrid] Remove gridKeyboardMultipleKeySelector in useGridSelection #1437

m4theushw opened this issue Apr 19, 2021 · 2 comments · Fixed by #1813
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes

Comments

@m4theushw
Copy link
Member

m4theushw commented Apr 19, 2021 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

useGridSelection relays in the state to detect if a multiple key is pressed (Shift or CTRL). This could be read from the event. There's an opportunity for an enhancement here that was raised in #1422 (comment).

Motivation 🔦

Use the event as single source of truth.
@m4theushw m4theushw added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 19, 2021
@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 19, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 19, 2021 •
edited
Loading

👍 It's what @joshwooding did as well on the TreeView to implement the multi selection, with the keyboard. As far as I know, it was already technically proven that it can work and that is will remove code in the grid.

@oliviertassinari oliviertassinari mentioned this issue Apr 20, 2021
Merged
@ZeeshanTamboli ZeeshanTamboli mentioned this issue Jun 5, 2021
Merged
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Jun 5, 2021 •
edited
Loading

@m4theushw @oliviertassinari I have linked this issue in PR #1813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Deselect row in non checkboxSelection grid ZeeshanTamboli/material-ui-x
3 participants
@oliviertassinari @ZeeshanTamboli @m4theushw