Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Date picker crash on mui.com #14422

Closed
oliviertassinari opened this issue Aug 31, 2024 · 10 comments
Closed

[pickers] Date picker crash on mui.com #14422

oliviertassinari opened this issue Aug 31, 2024 · 10 comments
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! website Related to the marketing pages

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 31, 2024

Steps to reproduce

Steps:

  1. Open https://mui.com/
  2. Click on the next month button icon

Current behavior

Screen.Recording.2024-09-01.at.00.29.02.mov

Context

https://x.com/bweston92/status/1829792875955028046

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 31, 2024
@github-actions github-actions bot added the component: pickers This is the name of the generic UI component, not the React module! label Aug 31, 2024
@michelengelen
Copy link
Member

Seems related to the transition:
Screenshot 2024-09-02 at 11 48 17

@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 2, 2024
@michelengelen
Copy link
Member

The demos in the docs work... so it might be specific to some styles in this demo.

@arthurbalduini
Copy link
Member

I did a quick investigation and there's a space being added to the SlideTransition classnames, perhaps involving the overrideResolver on the styled component, but I'm not being able to evolve much futher than that. Does anyone have more insights about it ? @LukasTy @flaviendelangle

Screenshot 2024-09-02 at 16 04 10

@alexfauquette
Copy link
Member

alexfauquette commented Sep 2, 2024

If that can help, the older docs build with the bug I found is this one mui/material-ui#43363

@romgrk could it be an unexpected side effect?

@romgrk
Copy link
Contributor

romgrk commented Sep 2, 2024

Yes, @oliviertassinari has an open & approved PR to restore the behavior: mui/material-ui#43537

@oliviertassinari
Copy link
Member Author

Oh wow, I would have never expected an extra space to cause a bug like this. I guess something broken around https://github.com/reactjs/react-transition-group/blob/2989b5b87b4b4d1001f21c8efa503049ffb4fe8d/src/CSSTransition.js#L11. Too bad that this dependency seems unmaintained, we can't fix it there.

@romgrk
Copy link
Contributor

romgrk commented Sep 2, 2024

We should also probably think about running mui-x tests in the core repo, it would make it more safe to refactor the core.

cc @mui/code-infra

@Janpot
Copy link
Member

Janpot commented Sep 3, 2024

We should also probably think about running mui-x tests in the core repo, it would make it more safe to refactor the core.

🙂 One could almost argue that X packages and @mui/material belong in the same repository.

@LukasTy
Copy link
Member

LukasTy commented Sep 3, 2024

Looks like the issue has been resolved with this fix: mui/material-ui#43537 and is no loner present in the deployed documentation.

@LukasTy LukasTy closed this as completed Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@oliviertassinari: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@oliviertassinari oliviertassinari added the website Related to the marketing pages label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! website Related to the marketing pages
Projects
None yet
Development

No branches or pull requests

7 participants