[test][data grid] aria-labels missing from mui-x

[annawatson-wk]

Steps to reproduce

Steps:

1. Open https://mui.com/x/react-data-grid/#mit-license-free-forever
2. Inspect the column header component.
3. Note there are no aria-labels on mui-x components.

Current behavior

MUI X components don't have aria-labels anymore.

https://mui.com/x/react-data-grid/#mit-license-free-forever

Expected behavior

MUI X components should have aria-labels.

https://v6.mui.com/x/react-data-grid/#mit-version-free-forever

Context

We had a couple of unit tests fail accessibility-wise for columnheader when upgrading to the latest version of mui-x from 7.13.0. Looking at it, it appears as though all the aria-labels from Data Grid are gone. Browsing the mui website, it looks like Date Picker is also effected. Is this intentional?

Your environment

npx @mui/envinfo

System:
    OS: macOS 13.6.2
  Binaries:
    Node: 20.8.1 - ~/.asdf/installs/nodejs/20.8.1/bin/node
    npm: 10.1.0 - ~/.asdf/plugins/nodejs/shims/npm
  Browsers:
    Chrome: 129.0.6668.71

Search keywords: aria-label aria label data grid pro date picker
Order ID: 82849

[oliviertassinari]

The a11y tree look correct:

so it looks like this change is right, it's a simplification.

So it looks like your question is about how to migrate the tests. I guess you are looking to use:

screen.getByRole('columnheader', { name: /first name/i })

this should be invariant, meaning work in both MUI X v6 and v7, I have tested this with https://testing-playground.com/.

[annawatson-wk]

Brilliant, that will work. We just wanted to make sure it was intentional.

[KenanYusuf]

Glad to hear it @annawatson-wk - I'll close the issue but feel free to re-open if you have any follow up questions.

[oliviertassinari]

I think this was closed a bit prematurely.

We just wanted to make sure it was intentional.

@annawatson-wk Yes, it fixes a bug, see #14482.

We had a couple of unit tests fail accessibility-wise for columnheader when upgrading to the latest version of mui-x from 7.13.0.

Could you share how you changed your tests? This would hopefully help the next developers who migrate from v6 to v7. Thanks.

it looks like Date Picker is also effected

I don't know about this.

[annawatson-wk]

accessibility-wise

This was probably a poor choice of words. We had a consumer unit testing aria-labels.

[oliviertassinari]

@annawatson-wk Alright, if you have more details about the pickers aria-label change, or test change, we can continue to discuss this, otherwise, it looks like we can close.

[github-actions]

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@annawatson-wk How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.