Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] 'log' axes & zoom cause warnings and grid breakdown due to non-unique child keys #15853

Closed
qwyble opened this issue Dec 11, 2024 · 4 comments
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!

Comments

@qwyble
Copy link

qwyble commented Dec 11, 2024

Steps to reproduce

Steps:

  1. Open this link to live example: https://codesandbox.io/p/sandbox/fast-cloud-pwx7wp
  2. Open preview console
  3. Observe warnings
  4. Usage with 'zoom' for LineChartPro results in grid breakdown due to this issue.

Current behavior

Console sprays warnings.

Screenshot 2024-12-11 at 10 50 15 AM

Using 'zoom' parameters in LineChartPro causes complete grid breakdown due to this same issue.

Expected behavior

Console should not spray warnings, child elements should have unique keys.
Zoom should not break the grid.

Context

This occurs when using 'log' axes and when modifying axes using zoom parameters, likely due to ticks being used to provide keys to the grid.

Your environment

ENV: Chromium

Search keywords: LineChart, LineChartPro, grid, GridChart, log, zoom

@qwyble qwyble added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 11, 2024
@github-actions github-actions bot added the component: charts This is the name of the generic UI component, not the React module! label Dec 11, 2024
@michelengelen michelengelen changed the title LineChart / LineChartPro "grid" and GridChart - 'log' axes & zoom cause warnings and grid breakdown due to non-unique child keys [charts] 'log' axes & zoom cause warnings and grid breakdown due to non-unique child keys Dec 12, 2024
@michelengelen
Copy link
Member

Hey @qwyble ... I am not able to reproduce this locally, but it does reproduce in the codesandbox. This may be a problem with CSB 🤷🏼

Did any of you encounter this before @JCQuintas or @alexfauquette ?

Screen.Recording.2024-12-12.at.12.15.09.mov

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 12, 2024
@JCQuintas
Copy link
Member

@michelengelen I believe we fixed it here: #15463

But it wasn't properly cherrypicked, might explain why you are not seeing it locally

@JCQuintas
Copy link
Member

Fixed on #15864

Thanks for reporting 👍

@JCQuintas JCQuintas removed the status: waiting for author Issue with insufficient information label Dec 12, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@qwyble How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants