Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Replace onOpen / onClose with onOpenChange #15859

Open
flaviendelangle opened this issue Dec 12, 2024 · 0 comments
Open

[pickers] Replace onOpen / onClose with onOpenChange #15859

flaviendelangle opened this issue Dec 12, 2024 · 0 comments
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait

Comments

@flaviendelangle
Copy link
Member

flaviendelangle commented Dec 12, 2024 •
edited
Loading

Why?

It's the nomenclature that Base UI is following.

They have the following signature: (open, event) => void.

Side note: it seems that they put the event in the 2nd param, it would be interesting to follow if @mui/material adopt this approach as well, in which case it would be a bad idea for us to work on #4729.

I'm adding the "on hold" label to make sure we wait for Base UI to be stable before working on this kind of breaking changes.

Search keywords:
@flaviendelangle flaviendelangle added component: pickers This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait breaking change labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flaviendelangle