Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] React 18 #1870

Closed
4 of 5 tasks
oliviertassinari opened this issue Jun 10, 2021 · 7 comments
Closed
4 of 5 tasks

[DataGrid] React 18 #1870

oliviertassinari opened this issue Jun 10, 2021 · 7 comments
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature umbrella For grouping multiple issues to provide a holistic view

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 10, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

This is an umbrella issue to keep track of the effort necessary toward supporting React 18. It might be painful. We will learn more once the core supports it (effort lead by Sebastian).

Details ✍️

let renderCellCount = 0;
function CounterRender(props) {
React.useEffect(() => {
if (props.value === 'Nike') {
renderCellCount += 1;
}
});
return props.value;
}

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! umbrella For grouping multiple issues to provide a holistic view labels Jun 10, 2021
@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait label Jun 10, 2021
@oliviertassinari oliviertassinari added new feature New feature or request and removed core Infrastructure work going on behind the scenes labels Jan 7, 2022
@fahadashiq12
Copy link

Is MUI Data Grid Table compatible with React 18?

import { DataGridPro } from '@mui/x-data-grid-pro';
import { useDemoData } from '@mui/x-data-grid-generator';

I am installing both but doesn't work out..

@flaviendelangle
Copy link
Member

@m4theushw I let you answer 👍

@david-schopf
Copy link

Is MUI Data Grid Table compatible with React 18?

import { DataGridPro } from '@mui/x-data-grid-pro'; import { useDemoData } from '@mui/x-data-grid-generator';

I am installing both but doesn't work out..

The peer dependency is locked to React 17

@m4theushw
Copy link
Member

The next release will be compatible with React 18.

@shivamchamoli09
Copy link

@m4theushw , @flaviendelangle any updates on this release which is going to be for react 18 compatibility.

@flaviendelangle
Copy link
Member

flaviendelangle commented Jun 27, 2022

@shivamchamoli09 the DataGrid is compatible with React 18 since v5.9.0: https://github.com/mui/mui-x/releases/tag/v5.9.0.

This issue is only open because we need to migrate some of our tooling (the benchmarks mainly) to be compatible fully with React 18

@echorohit

This comment was marked as off-topic.

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature and removed new feature New feature or request on hold There is a blocker, we need to wait labels Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

7 participants