Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Arrow navigation stuck in Action Cells #3005

Closed
2 tasks done
Edelf opened this issue Oct 27, 2021 · 4 comments · Fixed by #3375
Closed
2 tasks done

[DataGrid] Arrow navigation stuck in Action Cells #3005

Edelf opened this issue Oct 27, 2021 · 4 comments · Fixed by #3375
Assignees
Labels
accessibility a11y bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!

Comments

@Edelf
Copy link

Edelf commented Oct 27, 2021

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When using the keyboard arrows to navigate from cell to cell, if the cell is an GridActionsCellItem, the user can no longer navigate out of that cell.
Additionally, pressing enter on an Action keeps it in focus forever (see steps to reproduce).

Expected behavior 🤔

The user should be able to navigate using keyboard arrows to navigate out of the ActionCells.

Steps to reproduce 🕹

Steps:

  1. Go to https://codesandbox.io/s/cqiqw?file=/demo.tsx (Straight from docs)
  2. Select the first cell in the first row
  3. Using arrows, navigate to the last column (Actions)
  4. You can no longer navigate out of that cell using arrows.
    Additionally:
  5. Still using the keyboard, hit enter on the pencil
  6. Hit Tab to select the X (cancel) and hit enter
  7. The trash icon is selected/in focus forever

Context 🔦

We want the user to be able to navigate through the grid using tab and arrow keys

Your environment 🌎

`npx @material-ui/envinfo`
System:
    OS: Windows 10 10.0.19043
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz  
  Binaries:
    Node: 16.6.1 - c:\program files\nodejs\node.EXE
    Yarn: 1.22.15 - c:\program files (x86)\yarn\bin\yarn.CMD
    npm: 7.20.3 - c:\program files\nodejs\npm.CMD
  IDEs:
    VSCode: 1.61.2 - c:\program files\microsoft vs code\bin\code.CMD
Browsers:
    Chrome: 95.0.4638.54

Order ID 💳 (optional)

#28950

@Edelf Edelf added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 27, 2021
@DanailH
Copy link
Member

DanailH commented Oct 27, 2021

Hi @Edelf thanks for raising this but it is a duplicate of #2914.
You can track this ticket #2880 for when to expect a fix for this. The solution will also fix the problem with the actions column.

@DanailH DanailH added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 27, 2021
@DanailH DanailH closed this as completed Oct 27, 2021
@Edelf
Copy link
Author

Edelf commented Oct 27, 2021

@DanailH thank you for the quick response.
Is there a way to navigate from cell to cell using tab, similar to what happens when the row is in edit mode?

@DanailH
Copy link
Member

DanailH commented Oct 27, 2021

Navigating between grid cells is done using the arrows. You can check all the existing combinations here https://mui.com/components/data-grid/accessibility/#keyboard-navigation. The edit example is to make it easier.

@Edelf
Copy link
Author

Edelf commented Dec 6, 2021

@DanailH this problem is still happening.
Same codebox, but with 5.1.0: https://codesandbox.io/s/fullfeaturedcrudgrid-material-demo-forked-xv21n?file=/demo.tsx

Once the user navigates to the Actions column using the arrow keys, he cannot leave.

@m4theushw m4theushw reopened this Dec 7, 2021
@m4theushw m4theushw changed the title Arrow navigation stuck in Action Cells [DataGrid] Arrow navigation stuck in Action Cells Dec 7, 2021
@m4theushw m4theushw added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! and removed duplicate This issue or pull request already exists labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
4 participants