Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Do not fallback on valueToRender when children === null #5612

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #7023
Closed
Tracked by #3287

[data grid] Do not fallback on valueToRender when children === null #5612

joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #7023
Assignees
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience v6.x

Comments

@joserodolfofreitas
Copy link
Member

Summary

In GridCell, do not fallback on valueToRender when children === null but only when children === undefined

if (children == null) {
return <div className={classes.content}>{valueToRender?.toString()}</div>;
}

Motivation

DX: To allow to return null in render cells.

@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x dx Related to developers' experience labels Jul 26, 2022
@MBilalShafi MBilalShafi self-assigned this Nov 22, 2022
@MBilalShafi MBilalShafi moved this to 🆕 Needs refinement in MUI X Data Grid Nov 27, 2022
@MBilalShafi MBilalShafi moved this from 🆕 Needs refinement to 🏗 In progress in MUI X Data Grid Nov 27, 2022
@MBilalShafi MBilalShafi moved this from 🏗 In progress to 👀 In review in MUI X Data Grid Nov 28, 2022
@MBilalShafi MBilalShafi moved this from 👀 In review to ✅ Done in MUI X Data Grid Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience v6.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants