Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Remove the NavigationKeyDown events #5617

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6863
Closed
Tracked by #3287

[data grid] Remove the NavigationKeyDown events #5617

joserodolfofreitas opened this issue Jul 26, 2022 · 0 comments · Fixed by #6863
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v6.x

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Jul 26, 2022 •
edited by m4theushw
Loading

Summary

Remove the cellNavigationKeyDown and columnHeaderNavigationKeyDown events

mui-x/packages/grid/x-data-grid/src/models/events/gridEvents.ts

Line 100 in b778028

cellNavigationKeyDown = 'cellNavigationKeyDown',

mui-x/packages/grid/x-data-grid/src/models/events/gridEvents.ts

Line 152 in b778028

columnHeaderNavigationKeyDown = 'columnHeaderNavigationKeyDown',

Motivation

From #3193

On v6 I think we should replace the cellNavigationKeyDown and columnHeaderNavigationKeyDown with apiRef methods.
For me events should be "hey I did X, do whatever you want with this information" not "hey, could someone listen to me and do X".
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@joserodolfofreitas joserodolfofreitas changed the title Remove the cellNavigationKeyDown and columnHeaderNavigationKeyDown events mui-x/packages/grid/x-data-grid/src/models/events/gridEvents.ts Line 100 in b778028 cellNavigationKeyDown = 'cellNavigationKeyDown', mui-x/packages/grid/x-data-grid/src/models/events/gridEvents.ts Line 152 in b778028 columnHeaderNavigationKeyDown = 'columnHeaderNavigationKeyDown', [data grid] Remove the cellNavigationKeyDown and columnHeaderNavigationKeyDown events Jul 26, 2022
@joserodolfofreitas joserodolfofreitas changed the title [data grid] Remove the cellNavigationKeyDown and columnHeaderNavigationKeyDown events [data grid] Remove the NavigationKeyDown events Jul 26, 2022
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x design: ux labels Jul 26, 2022
@m4theushw m4theushw mentioned this issue Nov 15, 2022
Merged
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Remove unnecessary keyboard navigation events m4theushw/mui-x
2 participants
@joserodolfofreitas @oliviertassinari