[DataGrid] Fix cell value type in quick filtering v7 #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
component: data grid
|
Deploy preview: https://deploy-preview-10884--material-ui-x.netlify.app/ |
cherniavskii
force-pushed
the
fix-cellValue-type-in-quick-filter-v7
branch
from
ecdef46 to
456018f
Compare
MBilalShafi
approved these changes
Nov 3, 2023
cherniavskii
commented
Nov 4, 2023
| @@ -220,7 +221,7 @@ const getFilterCallbackFromItem = ( | |||
| if (ignoreDiacritics) { | |||
| value = removeDiacritics(value); | |||
| } | |||
| return applyFilterOnRow(value, row, column, apiRef); | |||
| return applyFilterOnRow(value, row, column, getPublicApiRef(apiRef)); | |||
There was a problem hiding this comment.
We were passing private apiRef here
There was a problem hiding this comment.
Can we create the API ref outside this function? I think this one is inside the filter loop, so we're doing O(n) allocations if we call getPublicApiRef here.
There was a problem hiding this comment.
Same comment applies below, line 420.
There was a problem hiding this comment.
Thanks for catching it, updated it!
Comment on lines
+17
to
+20
| let columnValue = apiRef.current.getRowFormattedValue(row, column); | ||
| if (apiRef.current.ignoreDiacritics) { | ||
| columnValue = removeDiacritics(columnValue); | ||
| } |
There was a problem hiding this comment.
This is a disadvantage compared to v6 filtering, where it was possible to overwrite the cellParams.formattedValue.
romgrk
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts c14f23c from #10569
I thought this was an optimization, but it turned out to cause issues with non-string column types.
E.g. for the
datecolumn type,valueis supposed to be of typeDate, while it currently isstring(because value formatter returns string).I have discovered this issue while working on #10581